这是indexloc提供的服务，不要输入任何密码
Skip to content

Various bits of trivial cleanup #58203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Various bits of trivial cleanup #58203

merged 1 commit into from
Jun 2, 2020

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented May 28, 2020

AspectRatio can test the ratio isn't zero. (The render object will
complain anyway, this just moves the exception earlier.)

@Hixie
Various bits of trivial cleanup
078169e 
AspectRatio can test the ratio isn't zero. (The render object will
complain anyway, this just moves the exception earlier.)
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label May 28, 2020
@Hixie
Copy link
Contributor Author

Hixie commented Jun 1, 2020

cc @HansMuller

HansMuller
HansMuller approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 74a2e6a into flutter:master Jun 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hixie @HansMuller @googlebot @fluttergithubbot