Build routes even less #58202
Merged
Build routes even less #58202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @chunhtai |
chunhtai
reviewed
Jun 1, 2020
| final List<String> log = <String>[]; | ||
| Route<dynamic> nextRoute = PageRouteBuilder<int>( | ||
| pageBuilder: (BuildContext context, Animation<double> animation, Animation<double> secondaryAnimation) { | ||
| log.add('building page 1 - ${ModalRoute.of(context).canPop}'); |
There was a problem hiding this comment.
Why do we care about can pop?
There was a problem hiding this comment.
It used to change value (that's why the pages rebuilt, basically). This is mostly making sure that it isn't rebuilding even if it's changing value.
There was a problem hiding this comment.
Not sure if I understand, the doc string of canPop does mention it should rebuild when the value changes
There was a problem hiding this comment.
Ah, I should update those docs. Good catch!
|
Docs updated, PTAL. |
fluttergithubbot
pushed a commit
that referenced
this pull request
Jun 16, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Aug 2, 2020
This reverts commit deec88b (PR flutter#59415. This was originally landed via PR flutter#58202.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.