[flutter_tools] remove execute permissions on shared.sh, and move off path #58267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal so that it is off the path
|
I put back the shebang, as it made the license check in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
flutter/bin/shared.shwas originally created by renamingflutter/bin/flutter, it inherited execute permissions and the shebang at the top. As it is only being sourced for function definitions, it needs neither of these, so this PR removes them. It also moves them fromflutter/bin/shared.sh->flutter/bin/internal/shared.shso that it doesn't appear on the path if the user has addedflutter/binto their path (it would have been a no-op if they executed it previously).