Helpful assertion for isAlwaysShown error #58258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onatcipli Does this look good to you? I wanted to make sure people understand they need to pass a controller to avoid confusion like in #53771 (comment). |
LongCatIsLooong
approved these changes
May 29, 2020
| } | ||
|
|
||
| expect(() async { | ||
| await tester.pumpWidget(viewWithScroll()); |
There was a problem hiding this comment.
Will this test pass prior to the change? Before this change the assert should still trigger at the end of the frame right?
There was a problem hiding this comment.
I just tried it and it fails prior to the change (so does the corresponding material test).
It does still throw an error though, but I guess it's happening in the post frame callback and so it's not caught by this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a scrollbar's isAlwaysShown is true, it must have a controller that's attached to a scrollview. Previously, an assertion deeper in the framework would get triggered if this wasn't the case, with an error message that's not so informative. This PR adds an assertion directly in the constructor with a more helpful error message.
Related Issues
Closes #53771
Tests
I added the following tests: