Automatically scale down Dialog padding for larger text scale factors #58245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Jun 10, 2020
johnsonmh
approved these changes
Jun 10, 2020
| @@ -11,7 +11,7 @@ import 'package:matcher/matcher.dart'; | |||
|
|
|||
| import '../widgets/semantics_tester.dart'; | |||
|
|
|||
| MaterialApp _buildAppWithDialog(Widget dialog, { ThemeData theme }) { | |||
| MaterialApp _buildAppWithDialog(Widget dialog, { ThemeData theme, double textScaleFactor = 1.0}) { | |||
There was a problem hiding this comment.
nit: space here to match other {
Suggested change
| MaterialApp _buildAppWithDialog(Widget dialog, { ThemeData theme, double textScaleFactor = 1.0}) { | |
| MaterialApp _buildAppWithDialog(Widget dialog, { ThemeData theme, double textScaleFactor = 1.0 }) { |
HansMuller
reviewed
Jun 15, 2020
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The paddings on the outer edges of dialog content (not between content) should be smaller for larger text scale size. This PR computes a factor for scaling down the padding and applies it to the space between the edge of the dialog and the content inside.
before:
after:
Related Issues
Tests
I added the following tests:
25 padding tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.