show admin options if logged in as admin only #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 94.16% 94.16% -0.01%
==========================================
Files 290 290
Lines 13977 13992 +15
==========================================
+ Hits 13162 13176 +14
- Misses 815 816 +1
Continue to review full report at Codecov.
|
jstucke
requested changes
Apr 11, 2018
src/helperFunctions/web_interface.py
Outdated
|
|
||
|
|
||
| def is_superuser(user): | ||
| if isinstance(user._get_current_object(), AnonymousUser): # auth disabled |
Collaborator
There was a problem hiding this comment.
it would be more intuitive if this functionality was put in its own function (e.g. "auth_is_enabled(user)"), since it has little to do with whether or not the user is a "superuser"
it would then need to be tested first (e.g. "if not auth_is_enabled(user) or is_superuser(user)")
Collaborator
There was a problem hiding this comment.
user_has_admin_clearance()
| other_versions=other_versions, | ||
| uids_for_comparison=uids_for_comparison) | ||
| uids_for_comparison=uids_for_comparison, | ||
| show_admin_panal=is_superuser(current_user)) |
| </div> | ||
| {# admin buttons #} | ||
| {% if firmware.vendor %} | ||
| {% if firmware.vendor and show_admin_panal %} |
jstucke
approved these changes
Apr 12, 2018
weidenba
pushed a commit
that referenced
this pull request
Oct 22, 2018
show admin options if logged in as admin only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.