这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dorpvom
Copy link
Member

@dorpvom dorpvom commented Mar 23, 2018

No description provided.

@dorpvom dorpvom self-assigned this Mar 23, 2018
@dorpvom dorpvom requested a review from weidenba March 23, 2018 13:32
@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@277eaf8). Click here to learn what that means.
The diff coverage is 98.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage          ?   94.17%           
=========================================
  Files             ?      288           
  Lines             ?    13998           
  Branches          ?        0           
=========================================
  Hits              ?    13182           
  Misses            ?      816           
  Partials          ?        0
Impacted Files Coverage Δ
src/web_interface/components/jinja_filter.py 87.5% <100%> (ø)
src/test/unit/web_interface/test_filter.py 100% <100%> (ø)
src/web_interface/filter.py 88.05% <100%> (ø)
...t/integration/storage/test_db_interface_backend.py 100% <100%> (ø)
src/scheduler/Analysis.py 90.14% <100%> (ø)
src/test/unit/helperFunctions/test_tag.py 100% <100%> (ø)
src/storage/db_interface_common.py 83.41% <100%> (ø)
...rypto_material/test/test_plugin_crypto_material.py 100% <100%> (ø)
src/test/unit/scheduler/test_analysis_tag.py 100% <100%> (ø)
src/objects/file.py 97.22% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277eaf8...6485889. Read the comment docs.

{% block analysis_result_details %}

{% for key in firmware.processed_analysis[selected_analysis] %}
{% if key not in ['summary', 'plugin_version', 'analysis_date'] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change should be applied to src/web_interface/templates/analysis_plugins/generic.html as well

@weidenba weidenba merged commit c68803d into master Apr 4, 2018
weidenba added a commit that referenced this pull request Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants