Known vulnerability plugin #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 93.85% 93.95% +0.09%
==========================================
Files 279 284 +5
Lines 13348 13620 +272
==========================================
+ Hits 12528 12796 +268
- Misses 820 824 +4
Continue to review full report at Codecov.
|
…nown-vulnerability-plugin
weidenba
suggested changes
Mar 21, 2018
Contributor
weidenba
left a comment
There was a problem hiding this comment.
It should be possible to a add a link to more informations regarding the bug. E.g. a link to the CVE entry.
| return new_results, summary | ||
|
|
||
| def _check_software_components(self, software_components_result): | ||
| found_vulnerabilities = list() |
Contributor
There was a problem hiding this comment.
4 levels of indent is quite a lot. Consider refactoring.
weidenba
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect known vulnerabilities based on