added script #82
added script #82
Conversation
dorpvom
left a comment
There was a problem hiding this comment.
Script is not well thought out. Some parts are not needed, others are missing. The tests fail and not all use cases are working.
| signal.signal(signal.SIGTERM, shutdown) | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
The command_line_options have to be given as parameter (and propagated to program_setup).
| analysis_service = AnalysisScheduler(config=config) | ||
| analysis_service.shutdown() | ||
| logging.info('Restart Analysis component') | ||
| analysis_service = AnalysisScheduler(config=config) |
There was a problem hiding this comment.
Why Start the Scheduler twice?
Also: The CompareScheduler has to also be started, as it also does view sync.
| @@ -0,0 +1,43 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Script missing shebang and execution permissions
| try: | ||
| pass | ||
| except KeyboardInterrupt: | ||
| break |
There was a problem hiding this comment.
I don't want to kill this manually. Instead just wait some seconds and then start the teardown
|
|
||
|
|
||
| @pytest.mark.parametrize('script', [init_database, migrate_database, update_statistic, update_variety_data]) | ||
| @pytest.mark.parametrize('script', [init_database, migrate_database, update_statistic, update_variety_data, restart_analysis_and_reload_templates]) |
There was a problem hiding this comment.
test fails. See above for reasons.
| PROGRAM_DESCRIPTION = 'Restart FACT Analysis Component and reload Analysis Templates' | ||
|
|
||
|
|
||
| def shutdown(signum, frame): |
There was a problem hiding this comment.
not needed if script self destroys (also applies for lines 20 + 21)
dorpvom
left a comment
There was a problem hiding this comment.
One request still open. Please change and issue a new jenkins build.
| @@ -0,0 +1,43 @@ | |||
| import logging | |||
…nalysis_and_reload_templates
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage ? 94.12%
=========================================
Files ? 291
Lines ? 14102
Branches ? 0
=========================================
Hits ? 13273
Misses ? 829
Partials ? 0
Continue to review full report at Codecov.
|
|
Before merging into master, master has to be merged into this branch and the script has to be moved to a suitable location ( != src ) |
…estart_analysis_and_reload_templates
…estart_analysis_and_reload_templates
No description provided.