Add file header plugin #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 93.75% 93.78% +0.02%
==========================================
Files 269 271 +2
Lines 12933 13043 +110
==========================================
+ Hits 12125 12232 +107
- Misses 808 811 +3
Continue to review full report at Codecov.
|
weidenba
suggested changes
Mar 14, 2018
Contributor
weidenba
left a comment
There was a problem hiding this comment.
Looks good to me. But it should be shown, which file you are looking at.
| from flask import Markup | ||
|
|
||
| from compare.PluginBase import CompareBasePlugin | ||
| from storage.binary_service import BinaryService |
|
|
||
| from flask import Markup | ||
|
|
||
| from storage.binary_service import BinaryService |
| @@ -0,0 +1,29 @@ | |||
| from unittest.mock import patch | |||
|
|
|||
weidenba
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New compare plugin providing a "binwalk -Ww"-ish view on the first 512 byte block of all compared files