Refactoring and test coverage #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ACT_core into refactoring_and_test_coverage
…ng_and_test_coverage
…ng_and_test_coverage
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage ? 93.62%
=========================================
Files ? 269
Lines ? 12730
Branches ? 0
=========================================
Hits ? 11919
Misses ? 811
Partials ? 0
Continue to review full report at Codecov.
|
Contributor
|
All in all, it looks pretty fine to me! |
Contributor
|
@dorpvom please add me to authorized collaborators in order to merge it! |
weidenba
pushed a commit
that referenced
this pull request
Oct 22, 2018
Refactoring and test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, added a list of tests for
Minor refactoring was needed to the productive code.
Second, code was deleted that was only used by an internal plugin. The code was instead added to said plugin.