Avm sqfs unpacker #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage ? 90.05%
=========================================
Files ? 248
Lines ? 11645
Branches ? 0
=========================================
Hits ? 10487
Misses ? 1158
Partials ? 0
Continue to review full report at Codecov.
|
tbarabosch
suggested changes
Dec 20, 2017
| return {'output': output} | ||
| unpack_result = dict() | ||
| for unpacker in squash_unpacker: | ||
| output = execute_shell_command('fakeroot {} -d {}/faf_extracted {}'.format(unpacker, tmp_dir, file_path)) |
Contributor
There was a problem hiding this comment.
faf is legacy, right? Should be fact.
|
|
||
|
|
||
| def _unpack_success(tmp_dir): | ||
| return len(get_files_in_dir(tmp_dir)) > 0 |
Contributor
There was a problem hiding this comment.
Can it happen that there is one accidental file? Add another more fuzzy test to see if there are folders like /bin or /var...
tbarabosch
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.