这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Dec 8, 2017

New feature: device names are now sorted on the upload page.
Refers to internal issue 34 "Device Names not sorted on Upload page".

@jstucke jstucke requested review from dorpvom and weidenba December 8, 2017 09:41
Copy link
Member

@dorpvom dorpvom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once jenkins returns clean.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2bc71e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   89.97%           
=========================================
  Files             ?      248           
  Lines             ?    11617           
  Branches          ?        0           
=========================================
  Hits              ?    10452           
  Misses            ?     1165           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc71e8...3cf7548. Read the comment docs.

Copy link
Member

@dorpvom dorpvom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is approved by JvD

@dorpvom dorpvom merged commit 248d3ed into master Dec 18, 2017
@weidenba weidenba deleted the i34-device-names-not-sorted branch December 20, 2017 08:11
weidenba pushed a commit that referenced this pull request Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants