18 version relation #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidenba
suggested changes
Dec 1, 2017
| self.assertEqual(self.db_frontend_interface.get_number_of_total_matches(query, only_parent_firmwares=True), 1) | ||
|
|
||
| def test_get_other_versions_of_firmware(self): | ||
| parent_fw1 = create_test_firmware(version="1") |
Contributor
There was a problem hiding this comment.
Coding convention violated!
" -> '
src/test/common_helper.py
Outdated
|
|
||
|
|
||
| def create_test_firmware(device_class="Router", device_name="test_router", vendor="test_vendor", bin_path="container/test.zip", all_files_included_set=False): | ||
| def create_test_firmware(device_class="Router", device_name="test_router", vendor="test_vendor", bin_path="container/test.zip", |
Contributor
There was a problem hiding this comment.
Coding convention violation
" -> '
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 90% 90.01% +<.01%
==========================================
Files 247 247
Lines 11569 11517 -52
==========================================
- Hits 10413 10367 -46
+ Misses 1156 1150 -6
Continue to review full report at Codecov.
|
weidenba
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.