8 quick search feature #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 90.02% 90.02% +<.01%
==========================================
Files 247 247
Lines 11385 11399 +14
==========================================
+ Hits 10249 10262 +13
- Misses 1136 1137 +1
Continue to review full report at Codecov.
|
dorpvom
reviewed
Nov 13, 2017
Member
dorpvom
left a comment
There was a problem hiding this comment.
Functionally okay. Only fix of style needed. Than ready to merge as soon as build succeeds.
| request_id=request_id, yara_rules=yara_rules) | ||
|
|
||
| def _app_start_quick_search(self): | ||
| search_term = request.args.get('search_term') |
| self.assertIn(self.test_fw.get_uid().encode(), rv.data, "test firmware not found in specific search") | ||
|
|
||
| def _show_quick_search(self): | ||
| rv = self.test_client.get('/database/quick_search?search_term=test_fw', follow_redirects=True) |
Member
There was a problem hiding this comment.
Quotation Mix. Please also fix in rest of file.
dorpvom
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.