这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dorpvom
Copy link
Member

@dorpvom dorpvom commented Nov 2, 2017

…orks.

New test did fail before fix was made. Functionality was only tested in unit tests prior. There the function is mocked and was named correctly.

@dorpvom dorpvom requested a review from weidenba November 2, 2017 13:34
@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #22 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage      90%   90.02%   +0.01%     
==========================================
  Files         247      247              
  Lines       11381    11385       +4     
==========================================
+ Hits        10244    10249       +5     
+ Misses       1137     1136       -1
Impacted Files Coverage Δ
src/storage/db_interface_frontend.py 85.48% <100%> (+0.53%) ⬆️
...ration/web_interface/rest/test_rest_file_object.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eafe21...e69a38a. Read the comment docs.

assert b'size' in rv.data

def test_rest_request_multiple_file_objects(self):
test_file_object = create_test_file_object()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused code

@weidenba weidenba merged commit 0079ea8 into master Nov 3, 2017
@dorpvom dorpvom deleted the 21-fix-bug-in-rest-api branch December 11, 2017 13:37
weidenba added a commit that referenced this pull request Oct 22, 2018
21: Fixed naming issue in endpoint. Added test to assert everything w…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants