Sd 269 hp unpacker #213
Merged
Sd 269 hp unpacker #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 95.71% 95.76% +0.04%
==========================================
Files 339 345 +6
Lines 17512 17699 +187
==========================================
+ Hits 16762 16949 +187
Misses 750 750
Continue to review full report at Codecov.
|
jstucke
reviewed
Feb 12, 2019
src/plugins/unpacking/hp/code/pjl.py
Outdated
|
|
||
| from common_helper_files import get_binary_from_file | ||
|
|
||
| INTERNAL_DIR = Path(Path(__file__).parent.parent, 'internal') |
Collaborator
There was a problem hiding this comment.
Creating multiple Path objects is not necessary. You can also use the / operator:
INTERNAL_DIR = Path(__file__).parent.parent / 'internal'
|
|
||
| def get_pjl_commands(input_data): | ||
| pjl_instructions = [] | ||
| tmp = list(re.finditer(b'@PJL [ =.!,?\w]+', input_data)) |
Collaborator
There was a problem hiding this comment.
DeprecationWarning: invalid escape sequence \w
should probably be a raw string rb'...'
|
|
||
|
|
||
| def _get_name_of_upgrade(raw_binary, upgrade_command): | ||
| tmp = re.search(b'\xa8\x01([\w ]+) [\w ]+', raw_binary[upgrade_command['end_offset']:upgrade_command['end_offset'] + NAME_FIELD_MAX]) |
|
|
||
|
|
||
| def _get_type_and_value(raw_command): | ||
| tmp = re.search(b'@PJL ([=\w]+) ?([ =.!,?\w]+)?', raw_command) |
Contributor
Author
|
tests run successfull: https://ci.die-weidenbachs.de/job/FACT_core_xenial-dev/522/console |
jstucke
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.