这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@euwint
Copy link
Collaborator

@euwint euwint commented Feb 5, 2019

No description provided.

@euwint euwint requested a review from dorpvom February 5, 2019 15:14
Copy link
Member

@dorpvom dorpvom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple failing tests. Also check if a test can be added to check new functionality.

@codecov-io
Copy link

Codecov Report

Merging #206 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   95.71%   95.72%   +<.01%     
==========================================
  Files         339      339              
  Lines       17512    17533      +21     
==========================================
+ Hits        16762    16783      +21     
  Misses        750      750
Impacted Files Coverage Δ
src/helperFunctions/dataConversion.py 100% <100%> (ø) ⬆️
src/web_interface/filter.py 89.91% <100%> (-0.18%) ⬇️
src/test/common_helper.py 95.27% <100%> (+0.04%) ⬆️
...c/test/unit/web_interface/test_app_jinja_filter.py 100% <100%> (ø) ⬆️
src/web_interface/components/analysis_routes.py 96.07% <100%> (+0.16%) ⬆️
src/test/acceptance/test_compare_firmwares.py 100% <100%> (ø) ⬆️
src/web_interface/components/jinja_filter.py 98.16% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdc0f1...f3bf778. Read the comment docs.

@dorpvom dorpvom merged commit 827d039 into master Feb 12, 2019
@dorpvom dorpvom deleted the show_known_comparisons branch February 12, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants