Fs metadata plugin #186
Merged
Fs metadata plugin #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 95.54% 95.68% +0.14%
==========================================
Files 330 334 +4
Lines 16597 17159 +562
==========================================
+ Hits 15857 16418 +561
- Misses 740 741 +1
Continue to review full report at Codecov.
|
tbarabosch
suggested changes
Dec 14, 2018
Contributor
tbarabosch
left a comment
There was a problem hiding this comment.
Looks good but there is a file of an old review with comments that shouldn't be in the repo!
| @@ -0,0 +1,49 @@ | |||
| quotation mix: | |||
Contributor
There was a problem hiding this comment.
This file shouldn't be here?!
weidenba
suggested changes
Dec 14, 2018
Contributor
weidenba
left a comment
There was a problem hiding this comment.
Please update the "Change Log" on the about page
Contributor
|
Looks fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved FS metadata plugin to core