这是indexloc提供的服务，不要输入任何密码
Skip to content

156 replace analysis caching #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 17, 2019
Merged

156 replace analysis caching #185

merged 25 commits into from
Jan 17, 2019

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Dec 5, 2018

addresses #156

@jstucke jstucke requested a review from dorpvom December 5, 2018 10:11
@codecov-io
Copy link

codecov-io commented Dec 6, 2018 •
edited
Loading

Codecov Report

Merging #185 into master will increase coverage by <.01%.
The diff coverage is 97.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   95.68%   95.69%   +<.01%     
==========================================
  Files         334      335       +1     
  Lines       17169    17292     +123     
==========================================
+ Hits        16429    16547     +118     
- Misses        740      745       +5
Impacted Files Coverage Δ
src/objects/file.py 97.22% <ø> (-0.03%) ⬇️
src/helperFunctions/dependency.py 100% <ø> (ø) ⬆️
src/storage/db_interface_frontend.py 90.52% <ø> (-0.1%) ⬇️
src/test/unit/scheduler/test_analysis.py 99.59% <100%> (-0.41%) ⬇️
src/helperFunctions/merge_generators.py 94% <100%> (+0.52%) ⬆️
src/test/integration/common.py 93.93% <100%> (+0.39%) ⬆️
src/storage/db_interface_common.py 95.47% <100%> (+0.04%) ⬆️
src/test/unit/analysis/test_plugin_base.py 100% <100%> (ø) ⬆️
src/test/unit/helperFunctions/test_dependency.py 94.73% <100%> (-1.82%) ⬇️
src/analysis/YaraPluginBase.py 90% <100%> (+0.95%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 314acc7...ce38e73. Read the comment docs.

@jstucke jstucke self-assigned this Jan 2, 2019
@weidenba weidenba mentioned this pull request Jan 3, 2019
Closed
@jstucke jstucke mentioned this pull request Jan 8, 2019
Closed
dorpvom
dorpvom reviewed Jan 11, 2019
View reviewed changes
Copy link
Member

@dorpvom dorpvom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see to these questions

dorpvom
dorpvom requested changes Jan 16, 2019
View reviewed changes
Copy link
Member

@dorpvom dorpvom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix broken tests after live fixes

@dorpvom dorpvom closed this Jan 16, 2019
@dorpvom dorpvom mentioned this pull request Jan 16, 2019
Closed
@jstucke jstucke reopened this Jan 16, 2019
@dorpvom dorpvom merged commit 56f8502 into master Jan 17, 2019
@dorpvom dorpvom deleted the 156-replace-analysis-caching branch January 17, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dorpvom dorpvom dorpvom approved these changes

+1 more reviewer

@weidenba weidenba weidenba left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jstucke jstucke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jstucke @codecov-io @weidenba @dorpvom