Align version naming #183
Merged
Align version naming #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Should close #164 |
weidenba
approved these changes
Nov 21, 2018
Contributor
weidenba
left a comment
There was a problem hiding this comment.
looks good to me, can be merged if tests pass
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 95.38% 95.37% -0.02%
==========================================
Files 326 326
Lines 16023 15994 -29
==========================================
- Hits 15284 15254 -30
- Misses 739 740 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing mismatched naming of firmware version, where in database and object
versionwas used and upload usedfirmware_version.Side effect: Removed unused function
convert_fw_obj_to_analysis_taskfrom task conversion helper.Name was already changed in wiki.