这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dorpvom
Copy link
Member

@dorpvom dorpvom commented Nov 7, 2018

Packets are now installed separately so that only the installation of specific packets fail.
Not that of all other packets that are installed with the packet in question.

@dorpvom dorpvom added the bug label Nov 7, 2018
@dorpvom dorpvom self-assigned this Nov 7, 2018
@dorpvom dorpvom requested a review from weidenba November 7, 2018 07:05
@dorpvom
Copy link
Member Author

dorpvom commented Nov 7, 2018

Should solve #175

Copy link
Contributor

@weidenba weidenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can be merge if tests run through.

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #176 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   95.37%   95.31%   -0.07%     
==========================================
  Files         316      316              
  Lines       15731    15743      +12     
==========================================
+ Hits        15004    15005       +1     
- Misses        727      738      +11
Impacted Files Coverage Δ
src/helperFunctions/install.py 33.62% <0%> (-3.88%) ⬇️
...test/integration/scheduler/test_cycle_with_tags.py 100% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2149ea5...ea3d0de. Read the comment docs.

@weidenba weidenba merged commit 14573bc into master Nov 7, 2018
@weidenba weidenba deleted the add-distutils-handling branch November 7, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants