dahua unpacker added #172
Merged
dahua unpacker added #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 95.37% 95.37% +<.01%
==========================================
Files 314 316 +2
Lines 15704 15731 +27
==========================================
+ Hits 14978 15004 +26
- Misses 726 727 +1
Continue to review full report at Codecov.
|
jstucke
approved these changes
Nov 5, 2018
|
|
||
|
|
||
| def unpack_function(file_path, tmp_dir): | ||
| output_file_path = Path(tmp_dir, 'dahua_firmware.zip') |
Collaborator
There was a problem hiding this comment.
imho it would look better in the file tree (and be more intuitive) if the original file name was kept and a ".zip" was appended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extraction plugin for dahua firmware images.
Dahua uses zip containers but change the magic bytes from 'PK' to 'DH'.