Locking unpacked files #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 95.73% 95.75% +0.01%
==========================================
Files 311 312 +1
Lines 15498 15586 +88
==========================================
+ Hits 14837 14924 +87
- Misses 661 662 +1
Continue to review full report at Codecov.
|
jstucke
reviewed
Oct 31, 2018
Collaborator
jstucke
left a comment
There was a problem hiding this comment.
the database with the locks should be dropped at startup to prevent undeletable artifacts of cancelled or crashed analyses
jstucke
requested changes
Oct 31, 2018
jstucke
reviewed
Oct 31, 2018
src/test/common_helper.py
Outdated
| return uid in self.locks | ||
|
|
||
| def release_unpacking_lock(self, uid): | ||
| self.locks.remove(uid) |
jstucke
reviewed
Oct 31, 2018
|
|
||
| def test_file_is_locked(self): | ||
| assert not self.unpacker.db_interface.check_unpacking_lock(self.test_fo.uid) | ||
| file_pathes = ['{}/get_files_test/testfile1'.format(get_test_data_dir())] |
jstucke
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem of race condition has appeared since binary deletion was activated recently.
Whenever a firmware is deleted, issuing a cascade of file deletions, a new analysis can overlap with the files. Then a file can be extracted during analysis, deleted shortly after due to the firmware deletion, and analyzed later on at which point the file has been deleted.
This happens basically every time a re-do anlysis is issued, but can happen in other scenarios as well.
A locking of extracted files should prevent that from happening. That is:
As of now, if a deletion request is issued in between steps 3 and 5, the file is remove as no database link exists to it. Once step 5 is processed, a new link in the database exists and the lock can be safely removed. As long as the lock is in place, any deletion attempt will be discarded.