Python based installation #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core into python-based-installation
…core into python-based-installation
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
- Coverage 95.75% 95.37% -0.39%
==========================================
Files 312 314 +2
Lines 15584 15704 +120
==========================================
+ Hits 14923 14977 +54
- Misses 661 727 +66
Continue to review full report at Codecov.
|
weidenba
suggested changes
Oct 31, 2018
Contributor
weidenba
left a comment
There was a problem hiding this comment.
Does not work :(
$ src/install.py -U -N
[2018-10-31 11:30:48][install][INFO]: FACT Installer 1.0
Traceback (most recent call last):
File "src/install.py", line 148, in <module>
os.chdir('install')
FileNotFoundError: [Errno 2] No such file or directory: 'install'
Please correct install.md
weidenba
suggested changes
Oct 31, 2018
src/helperFunctions/install.py
Outdated
| return True | ||
|
|
||
|
|
||
| def check_if_executable_in_bin_folder(executable_name): |
Contributor
There was a problem hiding this comment.
this function does nothing?
src/helperFunctions/install.py
Outdated
| logging.info('{} {}'.format(action, ' '.join(packages))) | ||
|
|
||
|
|
||
| def apt_update_sources(): |
Contributor
There was a problem hiding this comment.
merge all functions that use execute_shell_command check return_code
weidenba
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request for feeback