Debian package unpacker #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 302 302
Lines 14959 14959
=======================================
Hits 14318 14318
Misses 641 641Continue to review full report at Codecov.
|
weidenba
suggested changes
Jul 31, 2018
|
|
||
|
|
||
| def unpack_function(file_path, tmp_dir): | ||
| if not program_is_callable("fakeroot"): |
Contributor
There was a problem hiding this comment.
new policy says: Do not check the installation in production code. Pytest should tell us anyhow
| from test.unit.unpacker.test_unpacker import TestUnpackerBase | ||
|
|
||
|
|
||
| TEST_DATA_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data') |
weidenba
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now debian packages are handled by the generic_carver. This results in the typical false positive .xz and .zlib archives.