这是indexloc提供的服务，不要输入任何密码
Skip to content

Plugin base v1 fixes #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Plugin base v1 fixes #1410

wants to merge 7 commits into from

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Sep 19, 2025

  • fixes:
    • removed mixin (which is now part of the base class) from individual plugin class definition
    • fixed test class names
    • added missing __init__.py
    • init() fixes (version should be semver, missing self when referencing metadata class)
    • plugins should not return None as result
    • removed plugin shutdown log spam
  • feat: better handling of failed analyses

@jstucke jstucke requested a review from euwint September 19, 2025 10:17
@jstucke jstucke self-assigned this Sep 19, 2025
@jstucke jstucke force-pushed the plugin-base-v1-fixes branch from 77e0406 to 66f6792 Compare September 26, 2025 09:54
@jstucke jstucke force-pushed the plugin-base-v1-fixes branch from 66f6792 to 1287915 Compare September 26, 2025 12:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.91139% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.93%. Comparing base (1e9ca48) to head (1287915).

Files with missing lines Patch % Lines
src/scheduler/analysis/plugin.py 29.41% 12 Missing ⚠️
...ins/analysis/example_plugin/code/example_plugin.py 55.55% 4 Missing ⚠️
src/test/unit/analysis/test_plugin_worker.py 94.93% 4 Missing ⚠️
...c/plugins/analysis/cwe_checker/code/cwe_checker.py 40.00% 3 Missing ⚠️
src/plugins/analysis/hashlookup/code/hashlookup.py 60.00% 2 Missing ⚠️
src/scheduler/analysis/scheduler.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
- Coverage   91.97%   91.93%   -0.04%     
==========================================
  Files         372      374       +2     
  Lines       21012    21131     +119     
==========================================
+ Hits        19325    19427     +102     
- Misses       1687     1704      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euwint euwint Awaiting requested review from euwint

At least 1 approving review is required to merge this pull request.

Assignees

@jstucke jstucke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jstucke @codecov-commenter