这是indexloc提供的服务，不要输入任何密码
Skip to content

Cpu architecture v1 #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2025
Merged

Cpu architecture v1 #1395

merged 5 commits into from
Sep 2, 2025

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 15, 2025 •
edited
Loading

  • renamed plugin directory to match internal plugin name
  • fixed an empty device_tree plugin result resulting in an error when collecting dependency results for the cpu_architecture plugin
  • converted the cpu_architecture to the new base class
  • added a new test to improve coverage (analyze/summarize was not yet tested)
  • fixed a bug in the ELF component that produced empty summary strings

@jstucke jstucke requested a review from euwint August 15, 2025 07:51
@jstucke jstucke self-assigned this Aug 15, 2025
@jstucke jstucke force-pushed the cpu-architecture-v1 branch 2 times, most recently from c24cd52 to 80bccf2 Compare August 15, 2025 13:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.06%. Comparing base (a392b42) to head (5684429).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ysis/cpu_architecture/internal/kconfig/__init__.py 90.90% 1 Missing ⚠️
...ins/analysis/cpu_architecture/internal/metadata.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
+ Coverage   91.90%   92.06%   +0.15%     
==========================================
  Files         372      372              
  Lines       20955    20959       +4     
==========================================
+ Hits        19259    19295      +36     
+ Misses       1696     1664      -32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstucke jstucke force-pushed the cpu-architecture-v1 branch from 3535d6b to 910d6e1 Compare August 19, 2025 13:43
jstucke added 5 commits August 27, 2025 14:28
@jstucke
chore: rename cpu_architecture plugin directory
3106baa 
to match plugin name
@jstucke
fix: device tree empty result fix
bd20fd5 
fix incompatibility of dependency schema reconstruction with empty device tree plugin result
@jstucke
feat: converted cpu_arch plugin to new base class
62da136
@jstucke
test: added test to cpu_arch plugin
738633a 
to improve coverage
@jstucke
fix: cpu_arch elf empty summary fix
5684429 
arm_isa may be None which leads to an empty string as summary entry. this commit fixes the check
@jstucke jstucke force-pushed the cpu-architecture-v1 branch from 910d6e1 to 5684429 Compare August 27, 2025 12:28
euwint
euwint approved these changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@jstucke jstucke merged commit d8794bf into master Sep 2, 2025
8 checks passed
@jstucke jstucke deleted the cpu-architecture-v1 branch September 2, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euwint euwint euwint approved these changes

Assignees

@jstucke jstucke

Labels

None yet

Projects

None yet

Milestone

Convert all analysis plugins to new b...

Development

Successfully merging this pull request may close these issues.

4 participants

@jstucke @codecov-commenter @euwint