这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: revised IP&URI template #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

feat: revised IP&URI template #1344

merged 1 commit into from
Apr 10, 2025

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Feb 6, 2025 •
edited
Loading

  • fixed order of keys ('interesting' URIs -> URIs -> IPv4 -> IPv6)
  • sorted results
  • don't display 'interesting' URIs twice (also in URIs)

@jstucke
feat: revised IP&URI template
c775f7e 
* fixed order of keys ('interesting' URIs -> URIs -> IPv4 -> IPv6)

* sorted results

* don't display 'interesting' URIs twice
@jstucke jstucke requested a review from dorpvom February 6, 2025 16:41
@jstucke jstucke self-assigned this Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (b977028) to head (c775f7e).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   92.53%   91.78%   -0.75%     
==========================================
  Files         381      376       -5     
  Lines       24395    21099    -3296     
==========================================
- Hits        22574    19366    -3208     
+ Misses       1821     1733      -88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

euwint
euwint approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jstucke jstucke merged commit 28cf45c into master Apr 10, 2025
10 checks passed
@jstucke jstucke deleted the improved-ip-uri-template branch April 10, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euwint euwint euwint approved these changes

@dorpvom dorpvom Awaiting requested review from dorpvom

Assignees

@jstucke jstucke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jstucke @codecov-commenter @euwint