feat: converted init_systems plugin to v1 #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
Coverage 91.90% 91.91%
=======================================
Files 372 372
Lines 20955 20915 -40
=======================================
- Hits 19259 19223 -36
+ Misses 1696 1692 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maringuu
previously requested changes
Feb 13, 2025
Collaborator
maringuu
left a comment
There was a problem hiding this comment.
Contrary to my comment above, I'm not sure if we should simplify this plugin to do the following:
- Detect init-systems by filename (As is done currently)
- Display the whole file contents in the frontend
Currently, the schema does not seem too useful to me.
What do you think?
52c566f to
87e3661
Compare
87e3661 to
94c4bc6
Compare
euwint
approved these changes
Sep 16, 2025
Collaborator
euwint
left a comment
There was a problem hiding this comment.
Looks good and works fine :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.