Fix file magic warnings #1300
Merged
Fix file magic warnings #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstucke
commented
Nov 15, 2024
- fixes warnings like 'Warning: using regular magic file ...'
- bump FW magic version to v0.2.2
to fix warnings like 'Warning: using regular magic file...' and also put the installation in its own method and make the version variable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1300 +/- ##
==========================================
- Coverage 91.94% 91.90% -0.04%
==========================================
Files 377 376 -1
Lines 22295 21038 -1257
==========================================
- Hits 20499 19336 -1163
+ Misses 1796 1702 -94 ☔ View full report in Codecov by Sentry. |
Collaborator
|
lgtm. |
maringuu
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.