System health stage3 #1338
Merged
System health stage3 #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f4c118 to
0a0accb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
- Coverage 92.55% 91.77% -0.79%
==========================================
Files 383 376 -7
Lines 24466 21008 -3458
==========================================
- Hits 22645 19280 -3365
+ Misses 1821 1728 -93 ☔ View full report in Codecov by Sentry. |
euwint
requested changes
Feb 12, 2025
Collaborator
There was a problem hiding this comment.
Separating the plugin cards into an own page definitely makes sense.
The new Analysis Plugin Status table does look good.
However, I have two change requests:
- The positional relationship between the numbers and the corresponding symbols (e.g. "currently processing") should be adjusted.
- The textual representation of the progress should be correctly centered within the progress bars. The respective progress bars are shown when clicking on "show details of the currently analysed firmware".
0a0accb to
8ff0dcf
Compare
removes the border that unintentionally appeared at some point
c166624 to
9cb44fc
Compare
9cb44fc to
8655068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.