fix flaky helper process tests #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and also speed them up a bit with events
euwint
approved these changes
Oct 28, 2024
| def breaking_process(wait: bool = False): | ||
| if wait: | ||
| sleep(0.5) | ||
| check_exceptions_finished.wait(timeout=5) |
Collaborator
There was a problem hiding this comment.
Maybe we could use adjustable timeouts through environment variables?
Collaborator
Author
There was a problem hiding this comment.
Good idea but it is probably best to do this for all sleep/wait times in the tests at once (and that is probably out of scope for this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.