Binary search: show matching string #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2baa3c to
5e71dc6
Compare
Member
|
Can we have it so, that these "overfull hboxes" don't exist? |
dorpvom
requested changes
Oct 8, 2024
Member
dorpvom
left a comment
There was a problem hiding this comment.
Please consider annotated requests
|
|
||
| @staticmethod | ||
| def _parse_raw_result(raw_result: str) -> dict[str, list[str]]: | ||
| def _parse_raw_result(raw_result: str, match_limit: int = 10) -> dict[str, dict[str, list[dict]]]: |
Member
There was a problem hiding this comment.
As far as I can see, the match_limit has of yet no way of being configured. Correct? Is that intentional? Otherwise it would probably fit under the general [backend] domain in the config (e.g. binary_search_limit).
Collaborator
Author
There was a problem hiding this comment.
Introduced a config variable for that
jstucke
added a commit
that referenced
this pull request
Oct 8, 2024
* removed unused method _query_has_only_one_result from database routes * removed unused artifact from GraphQL search from base.html
dorpvom
approved these changes
Oct 25, 2024
* removed unused method _query_has_only_one_result from database routes * removed unused artifact from GraphQL search from base.html
72bbb59 to
9296f2f
Compare
jstucke
added a commit
that referenced
this pull request
Oct 28, 2024
* db: add column to binary search cache for matched string data * feat: show matching strings in binary search * chore: replaced firmware_detail_tabular_field filter with macro * fix: fixed text overflow in search results * fix: fixed wording on DB browse/search results pagination * feat: made stored yara search strings count configurable * requested review changes #1270 * removed unused method _query_has_only_one_result from database routes * removed unused artifact from GraphQL search from base.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.