FW import/export #1278
Merged
FW import/export #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc9ce3c to
adfbfe8
Compare
cf88cf2 to
2859f86
Compare
euwint
requested changes
Oct 29, 2024
src/firmware_import_export.py
Outdated
| def main(): | ||
| args = _parse_args() | ||
| if args.command == 'export': | ||
| FwExporter(args.output).export_files(args.uids) |
Collaborator
There was a problem hiding this comment.
AttributeError: 'Namespace' object has no attribute 'uids'
"uids" is unknown because it is called "UIDs" in line 175. We should use a consistent spelling
src/firmware_import_export.py
Outdated
| except json.JSONDecodeError as error: | ||
| logging.error(f'Error: data.json is not a valid JSON file: {error}') | ||
| return | ||
| if not all(k in data for k in ['db_revision', 'files', 'firmware', 'uid']): |
Collaborator
There was a problem hiding this comment.
Perhaps we should explain in the description that a data.json is mandatory and which keys it must contain. Otherwise, users who want to use the tool to import firmware (which has not been exported before) will have to look at the code to find out which keys are needed
Collaborator
Author
There was a problem hiding this comment.
I added an message to the first error that explicitly states that the script is only for importing files that were previously exported by this script
2859f86 to
b013f43
Compare
b013f43 to
bef1471
Compare
euwint
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1250, resolves #446