Uefi plugin #1143
Open
Uefi plugin #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and also sorted results in the template by rule name
maringuu
reviewed
Oct 18, 2023
| run_docker_container( | ||
| DOCKER_IMAGE, | ||
| combine_stderr_stdout=True, | ||
| timeout=self.TIMEOUT, |
Collaborator
There was a problem hiding this comment.
This is part of the Mixin and should not be used.
Also I'd rather use functions instead of methods since plugins don't maintain state.
Collaborator
Author
There was a problem hiding this comment.
Oops I didn't intend to use it. This is more of an artifact from the pre-V1 plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.