Mypy hook #1123
Mypy hook #1123
Conversation
…arison ID type alias
…arison ID type alias
maringuu
left a comment
There was a problem hiding this comment.
Overall lgtm but still some questions.
src/analysis/plugin/plugin.py
Outdated
| :param analyses: A dictionary of dependent analysis | ||
| :return: The analysis if anything was found. | ||
| :return: The analysis results (if there are any). |
There was a problem hiding this comment.
nit: why use parentheses?
There was a problem hiding this comment.
In general? 😅
I don't know, if you want I can remove them. I originally just wanted to specify that analysis results are returned.
There was a problem hiding this comment.
I meant that what is written in the parentheses is useful information and reads better without the parantheses.
src/analysis/plugin/plugin.py
Outdated
| 'summary': summary, | ||
| 'tags': tags_dict, | ||
| 'result': result.dict() if result else None, | ||
| 'result': result.dict() if isinstance(result, BaseModel) else None, |
There was a problem hiding this comment.
I think during the time I wasn't sure if the plugin always returns a BaseModel or if it can be a dict if no schema is specified. I think as it is now, the schema is mandatory and the plugin always returns a BaseModel, right?
maringuu
left a comment
There was a problem hiding this comment.
I had a brief look at everything but didn't look in depth.
I hope I found any actual code changes and reviewed them.
For the typing changes I'm happy when mypy is.
| from multiprocessing import Value | ||
| from helperFunctions.types import MpValue, MpArray | ||
|
|
||
| pass |
|
We decided to split this up into smaller PRs to make each one reviewable |
Uh oh!
There was an error while loading. Please reload this page.