103 offsets in printable strings plugin #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 94.3% 94.33% +0.03%
==========================================
Files 294 294
Lines 14439 14498 +59
==========================================
+ Hits 13617 13677 +60
+ Misses 822 821 -1
Continue to review full report at Codecov.
|
weidenba
suggested changes
May 15, 2018
Contributor
weidenba
left a comment
There was a problem hiding this comment.
crashes on some firmware images:
[2018-05-15 08:12:16][PluginBase][WARNING]: Worker 0: Timeout printable_strings analysis on 801afaa74a2ae951e4f4fb261885342608b521d173a2bc8027f78c1a6713615f_26481084
Process ExceptionSafeProcess-28:4:
Traceback (most recent call last):
File "/usr/lib/python3.5/multiprocessing/process.py", line 249, in _bootstrap
self.run()
File "/home/weidenba/git/FACT_core_github/src/helperFunctions/process.py", line 59, in run
raise exception
File "/home/weidenba/git/FACT_core_github/src/helperFunctions/process.py", line 54, in run
Process.run(self)
File "/usr/lib/python3.5/multiprocessing/process.py", line 93, in run
self._target(*self._args, **self._kwargs)
File "/home/weidenba/git/FACT_core_github/src/analysis/PluginBase.py", line 125, in process_next_object
finished_task = self.analyze_file(task)
File "/home/weidenba/git/FACT_core_github/src/analysis/PluginBase.py", line 74, in analyze_file
fo = self.process_object(file_object)
File "/home/weidenba/git/FACT_core_github/src/plugins/analysis/string_evaluation/code/string_eval.py", line 30, in process_object
list_of_printable_strings = file_object.processed_analysis['printable_strings']['strings']
KeyError: 'strings'
| fo = FileObject(file_path=os.path.join(TEST_DATA_DIR, 'string_find_test_file2')) | ||
| fo = self.analysis_plugin.process_object(fo) | ||
| results = fo.processed_analysis[self.PLUGIN_NAME] | ||
| print(results) |
Contributor
There was a problem hiding this comment.
Debug message that should be removed?
weidenba
suggested changes
May 22, 2018
| @@ -1,3 +1,4 @@ | |||
| import pytest | |||
| ] | ||
|
|
||
| super().__init__(plugin_administrator, config=config, recursive=recursive, plugin_path=__file__) | ||
| def _get_min_length_from_config(self): |
Contributor
There was a problem hiding this comment.
is there a reason why we do not use the get function with Fallback Value:
https://docs.python.org/3/library/configparser.html
src/web_interface/filter.py
Outdated
| def filter_format_string_list_with_offset(offset_tuples): | ||
| max_offset_len = len(str(max(list(zip(*offset_tuples))[0]))) if offset_tuples else 0 | ||
| lines = [ | ||
| "{0: >{width}}: {1}".format(offset, repr(string), width=max_offset_len) |
weidenba
approved these changes
May 22, 2018
weidenba
added a commit
that referenced
this pull request
Oct 22, 2018
…s-plugin 103 offsets in printable strings plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #103