105 uid list download links #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstucke
approved these changes
Apr 27, 2018
| {% if fo['mime-type'] %} | ||
| Type: {{ fo['mime-type'] }} | ||
| {% endif %} | ||
| <span class="glyphicon glyphicon-download-alt pull-right clickable" onclick="location.href='/download/{{ fo.uid }}'"></span> |
Collaborator
There was a problem hiding this comment.
I suggest adding style="cursor: pointer" to the span so the user sees the familiar mouse pointer commonly associated with a "clickable" element when hovering over the download icon with the mouse
Collaborator
There was a problem hiding this comment.
the clickable class sadly doesn't seem to do the trick here
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage ? 94.27%
=========================================
Files ? 294
Lines ? 14437
Branches ? 0
=========================================
Hits ? 13610
Misses ? 827
Partials ? 0Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #105