这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dorpvom
Copy link
Member

@dorpvom dorpvom commented Apr 20, 2018

On backend-only installations, the import of ConnectTo causes an import error since flask_security is not installed. Thus the auth functions is moved out of place.

@dorpvom dorpvom self-assigned this Apr 20, 2018
@dorpvom dorpvom requested review from jstucke and weidenba April 20, 2018 12:18
@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #101 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   94.11%   94.12%   +<.01%     
==========================================
  Files         290      290              
  Lines       14076    14077       +1     
==========================================
+ Hits        13248    13250       +2     
+ Misses        828      827       -1
Impacted Files Coverage Δ
src/web_interface/security/authentication.py 100% <100%> (ø) ⬆️
src/helperFunctions/web_interface.py 85.18% <100%> (-1.49%) ⬇️
src/web_interface/components/analysis_routes.py 95.91% <100%> (+0.04%) ⬆️
...rc/test/unit/helperFunctions/test_web_interface.py 100% <100%> (ø) ⬆️
...test/integration/scheduler/test_cycle_with_tags.py 100% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a3e15...489798b. Read the comment docs.

@weidenba weidenba merged commit 9b32efb into master Apr 20, 2018
@weidenba weidenba deleted the fix-cross-dependency branch April 25, 2018 09:38
weidenba added a commit that referenced this pull request Oct 22, 2018
Moved flask_security dependend function to another module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants