chore(storage-resize-images): migration to Node.js v14 #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #657 +/- ##
=======================================
Coverage 50.65% 50.65%
=======================================
Files 30 30
Lines 1313 1313
Branches 193 193
=======================================
Hits 665 665
Misses 647 647
Partials 1 1 |
Member
Author
Testing |
mikehardy
reviewed
May 5, 2021
storage-resize-images/README.md
Outdated
| - This extension uses other Firebase and Google Cloud Platform services, which have associated charges if you exceed the service’s free tier: | ||
| - Cloud Storage | ||
| - Cloud Functions (Node.js 10+ runtime. [See FAQs](https://firebase.google.com/support/faq#expandable-24)) | ||
| - Cloud Functions (Node.js 12+ runtime. [See FAQs](https://firebase.google.com/support/faq#expandable-24)) |
There was a problem hiding this comment.
I was curious so I checked. New URL: https://firebase.google.com/support/faq#extensions-pricing
Member
Author
There was a problem hiding this comment.
Great spot Mike, reading that article suggest that this change probably isn't needed as part of the PR? As the document specifically notes v10+..?
Could always update that link as a separate PR?
There was a problem hiding this comment.
Mmm good point @dackers86 - probably leave 10+ runtime in the comment (since that is the version in the pricing document) but definitely point to the new URL
Salakar
approved these changes
May 11, 2021
jhuleatt
reviewed
May 11, 2021
Co-authored-by: Jeff <jhuleatt@google.com>
jhuleatt
reviewed
Jun 15, 2021
jhuleatt
reviewed
Jun 15, 2021
jhuleatt
reviewed
Jun 15, 2021
jhuleatt
approved these changes
Jun 15, 2021
pavelgj
added a commit
that referenced
this pull request
Jun 17, 2021
* chore(delete-user-data): refactor test data into delete user data (#655) * feat(*): added warsaw (europe-central2) location (#677) Co-authored-by: Rosário P. Fernandes <rosariofernandes51@gmail.com> * chore(storage-resize-images): migration to Node.js v14 (#657) * chore(storage-resize-images): migration to Node.js v12 * Undo readme, update preinstall * Documentation and package updates * Update storage-resize-images/README.md Co-authored-by: Jeff <jhuleatt@google.com> * node 12 to 14 Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com> Co-authored-by: Jeff <jhuleatt@google.com> * chore(delete-user-data): migration to Node.js v14 (#661) * chore(delete-user-data): migration to Node.js v12 * Updated engine to node14, build fixes and updated target lib * chore(firestore-counter): migration to Node.js v14 (#664) * chore(firestore-counter): migration to Node.js v12 * Updated engine to node14, build fixes and updated target lib * chore(firestore-send-email): migration to Node.js v14 (#665) * chore(firestore-send-email): migration to Node.js v12 * Updated engine to node14, build fixes and updated target lib * chore(firestore-shorten-urls-bitly): migration to Node.js v14 (#667) * chore(firestore-send-email): migration to Node.js v12 * chore(firestore-shortern-urls-bitly): migration to Node.js v12 * Updated engine to node14, build fixes and updated target lib * reverted send email updates * reverted additional send email updates * chore(firestore-translate-text): migration to Node.js v14 (#668) * chore(firestore-translate-text): migration to Node.js v12 * Updated engine to node14, build fixes and updated target lib * chore(rtdb-limit-child-nodes): migration to Node.js v14 (#669) * chore(rtdb-limit-child-nodes-node12): migration to Node.js v12 * Updated engine to run node14 * Updated target mapping and build fixes * chore(firestore-bigquery-export): migration to Node.js v14 (#662) * chore(firestore-bigquery-export): migration to Node.js v12 * Reverted change tracker updates, updated export dependencies * Updated engine to node14, build fixes and updated target lib * Update firestore-bigquery-export/functions/tsconfig.json Co-authored-by: Jeff <jhuleatt@google.com> Co-authored-by: Pavel Jbanov <pavelgj@gmail.com> * chore(*): regenerate release notes for June 21 2021 release (#680) Co-authored-by: Darren Ackers <ackers86@hotmail.com> Co-authored-by: Rosário P. Fernandes <rosariofernandes51@gmail.com> Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com> Co-authored-by: Jeff <jhuleatt@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Testing
Jest Tests
N/a for this module.
Updated engine
Successful Installation
Successful result following installation