[Infra] Bump podspec min. versions #15015

ncooke3 · 2025-06-20T19:25:46Z

CocoaPods fix for #14732

gemini-code-assist · 2025-06-20T19:25:50Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Firebase.podspec

Firestore/Example/GoogleBenchmark.podspec

Firestore/Example/GoogleTest.podspec

Firestore/Example/LibFuzzer.podspec

Firestore/Example/ProtobufCpp.podspec

GoogleAppMeasurement.podspec

FirebaseABTesting.podspec

FirebaseAppCheck.podspec

FirebaseAppCheckInterop.podspec

FirebaseAuth.podspec

FirebaseDatabase.podspec

FirebaseFirestoreTestingSupport.podspec

FirebaseFunctions.podspec

FirebaseMLModelDownloader.podspec

FirebaseMessaging.podspec

ncooke3 · 2025-06-23T19:45:37Z

RTDB

Restarted RTDB integration tests

Integration tests are silently failing in main. Not sure why this PR surfaced them when nightlies didn't. See silent failure in nightlies: https://github.com/firebase/firebase-ios-sdk/actions/runs/15821265434/job/44590876032#step:8:1595

Update: This requires more investigation, but I don't think it should block this PR.

paulb777 · 2025-06-24T15:45:46Z

Agreed that the RTDB integration tests shouldn't block.

ncooke3 · 2025-06-24T16:19:12Z

CI Failure: symbolcollision / installation-test (pull_request) is due to Firebase 12 incompatible GoogleTagManager release

paulb777

Can be done in a separate PR: The deprecateddynamicLinkDomain should be removed and changelogged.

FirebaseDatabase/Sources/third_party/SocketRocket/FSRWebSocket.m

ncooke3 · 2025-07-18T13:59:38Z

/gemini review

gemini-code-assist

Code Review

The pull request bumps the minimum deployment versions for iOS, tvOS, and watchOS across various Firebase podspecs and example projects. It also includes a code change to suppress deprecated declaration warnings in FSRWebSocket.m and adds backward compatibility for older OS versions in StorageUtils.swift.

gemini-code-assist · 2025-07-18T14:07:16Z

FirebaseStorage/Sources/Internal/StorageUtils.swift

@@ -71,21 +73,28 @@ class StorageUtils {
    return string.addingPercentEncoding(withAllowedCharacters: allowedSet)!
  }

-  class func MIMETypeForExtension(_ fileExtension: String?) -> String {
-    guard let fileExtension = fileExtension else {
+  static func MIMETypeForExtension(_ fileExtension: String?) -> String {


Changing class func to static func makes the function a type method, which is generally preferred for utility functions that don't rely on instance state. [^1]

Suggested change

static func MIMETypeForExtension(_ fileExtension: String?) -> String {

static func MIMETypeForExtension(_ fileExtension: String?) -> String {

ncooke3 · 2025-07-18T14:14:10Z

/gemini review. pay careful attention to the podspec file changes. apart from dependency version changes to 12.0.0, be on the lookout for any possible regressions

gemini-code-assist

Code Review

This PR bumps the minimum deployment targets for iOS and tvOS to 15.0, and watchOS to 7.0 across the project. The changes are extensive and touch many configuration files.

I've found a critical issue in Firebase.podspec and a few minor issues related to code style and correctness in other files. Please address them to maintain code quality.

gemini-code-assist · 2025-07-18T14:16:50Z

Firebase.podspec

    ss.osx.deployment_target = '10.15'
-    ss.tvos.deployment_target = '13.0'
+    ss.ios.deployment_target = '15.0'


This appears to be a copy-paste error. The tvos.deployment_target was replaced with another ios.deployment_target. It should be updated for tvOS instead.

ss.tvos.deployment_target = '15.0'

gemini-code-assist · 2025-07-18T14:16:50Z

FirebaseStorage/Sources/Internal/StorageUtils.swift

-        .takeRetainedValue() {
-        return mimeType as String
+    // TODO: Remove `else` when min. supported macOS is 11.0+.
+    if #available(macOS 11.0, iOS 14.0, tvOS 14.0, *) {


UTType(filenameExtension:) is available on watchOS 7.0 and later. Add watchOS 7.0 to this availability check to use the modern API on watchOS as well.

Suggested change

if #available(macOS 11.0, iOS 14.0, tvOS 14.0, *) {

if #available(macOS 11.0, iOS 14.0, tvOS 14.0, watchOS 7.0, *) {

gemini-code-assist · 2025-07-18T14:16:50Z

FirebaseCore/CHANGELOG.md

+    - | Platform  | Firebase 12 |
+      | ------------- | ------------- |
+      | iOS  | **15.0**  |
+      | tvOS  | **15.0**  |
+      | macOS  | 10.15  |
+      | watchOS  | 7.0  |


The markdown table is malformed, which will cause it to render incorrectly. Here's a corrected version that should render properly as a table within the list item.

Suggested change

- | Platform | Firebase 12 |

| ------------- | ------------- |

| iOS | **15.0** |

| tvOS | **15.0** |

| macOS | 10.15 |

| watchOS | 7.0 |

| Platform | Firebase 12 |

|-----------|-------------|

| iOS | **15.0** |

| tvOS | **15.0** |

| macOS | 10.15 |

| watchOS | 7.0 |

gemini-code-assist · 2025-07-18T14:16:50Z

FirebaseDatabase/Sources/third_party/SocketRocket/FSRWebSocket.m

+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
                    SecCertificateRef cert = SecTrustGetCertificateAtIndex(secTrust, i);
+#pragma clang diagnostic pop


This change adds a pragma to suppress a deprecation warning. While this is correct given the new minimum deployment target of iOS 15.0, consider replacing the deprecated function with its recommended alternative, SecTrustCopyCertificateChain, when time permits.

gemini-code-assist · 2025-07-18T14:16:50Z

GoogleAppMeasurement.podspec

    s.cocoapods_version = '>= 1.12.0'

-    s.ios.deployment_target  = '12.0'
+    s.ios.deployment_target = '15.0'


For improved readability, align the = signs.

s.ios.deployment_target = '15.0' s.osx.deployment_target = '10.15' s.tvos.deployment_target = '15.0'

ncooke3 added 3 commits June 20, 2025 15:17

[Infra] Bump podspec min. versions

9b40fdf

Adjust Podfiles

cb5ff0f

update deployment targets

bf2d68d

Merge branch 'main' into nc/min-os

dc9155d

ncooke3 commented Jun 20, 2025

View reviewed changes

ncooke3 added 3 commits June 20, 2025 15:45

Update Firebase.podspec

f067f5f

Apply suggestions from code review

ecac4b2

Apply suggestions from code review

68cb847

ncooke3 commented Jun 20, 2025

View reviewed changes

ncooke3 added 3 commits June 20, 2025 15:52

Update FirebaseABTesting.podspec

44c5145

Update FirebaseAppCheck.podspec

025c68b

Update FirebaseAppCheck.podspec

6566b39

ncooke3 added 2 commits June 20, 2025 16:10

changelog

a9c2a90

fix test platforms os

c8fdeb8

This comment was marked as outdated.

Sign in to view

ncooke3 and others added 5 commits June 23, 2025 18:24

Storage

f388b97

Guard deprecated code

1428519

Fix warning

3af7787

symbol collision fix

69c7e8b

Merge branch 'main' into nc/min-os

e4f8ea8

ncooke3 requested a review from paulb777 June 24, 2025 16:10

podfile

0dbb673

paulb777 approved these changes Jun 24, 2025

View reviewed changes

FirebaseDatabase/Sources/third_party/SocketRocket/FSRWebSocket.m Show resolved Hide resolved

ncooke3 merged commit a0fd16d into main Jun 24, 2025
453 of 458 checks passed

ncooke3 deleted the nc/min-os branch June 24, 2025 17:22

ncooke3 mentioned this pull request Jun 24, 2025

[Firebase 12]: Check upstream implementation of socket rocket to avoid deprecated code #15035

Closed

ncooke3 added this to the Firebase 12 - M167 milestone Jun 24, 2025

This was referenced Jun 24, 2025

Nightly Testing Report #15032

Closed

[Infra] For SPM, defer to Xcode for supported platform versions #15039

Merged

cherylEnkidu pushed a commit that referenced this pull request Jun 30, 2025

[Infra] Bump podspec min. versions (#15015)

4238fd8

github-actions bot mentioned this pull request Jul 16, 2025

Update to Firebase 12.0.0 afresh-technologies/firebase-ios-sdk-xcframeworks#96

Merged

paulb777 mentioned this pull request Jul 17, 2025

Restore pod Firebase/Firestore for tvOS #15127

Merged

gemini-code-assist bot reviewed Jul 18, 2025

View reviewed changes

firebase locked and limited conversation to collaborators Jul 24, 2025

	static func MIMETypeForExtension(_ fileExtension: String?) -> String {
	static func MIMETypeForExtension(_ fileExtension: String?) -> String {

	if #available(macOS 11.0, iOS 14.0, tvOS 14.0, *) {
	if #available(macOS 11.0, iOS 14.0, tvOS 14.0, watchOS 7.0, *) {

[Infra] Bump podspec min. versions #15015

[Infra] Bump podspec min. versions #15015

Uh oh!

Conversation

ncooke3 commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

ncooke3 commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RTDB

Uh oh!

paulb777 commented Jun 24, 2025

Uh oh!

ncooke3 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulb777 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ncooke3 commented Jul 18, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ncooke3 commented Jul 18, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ncooke3 commented Jun 20, 2025 •

edited

Loading

ncooke3 commented Jun 23, 2025 •

edited

Loading

ncooke3 commented Jun 24, 2025 •

edited

Loading