nit: Fix small bug in functions log MCP tool #9247
Conversation
taeold
commented
Oct 2, 2025
- Improve error message to include more useful error message from Cloud Logging
- Fix bug where asc/desc was incorrectly passed to cloud logging API call when it is absent in the tool arg.
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses minor issues within the Cloud Functions log retrieval tool. It primarily focuses on improving the robustness of error reporting by integrating a new error message utility and correcting how log ordering is handled, ensuring the tool behaves as expected even when optional parameters are not explicitly provided. Additionally, it refines the input validation for function names and sets a default page size. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a couple of nice fixes and improvements. The schema for function_names is simplified, and the error messaging is improved by using getErrMsg. I've found a couple of areas where the implementation can be further improved for clarity and correctness. Specifically, the logic for resolving the sort order can be made more concise, and the error handling can be adjusted to surface the more detailed underlying error message from the Cloud Logging API. Please see my detailed comments.