这是indexloc提供的服务，不要输入任何密码
Skip to content

Update minimum iOS deployment target to 15 #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

Update minimum iOS deployment target to 15 #1776

merged 1 commit into from
Jul 17, 2025

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Update the minimum iOS deployment target from 13 to 15, since the Firebase iOS library has done so.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 16, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the minimum iOS and tvOS deployment targets for the Firebase C++ SDK and its associated integration tests from version 13.0 to 15.0. This necessary change aligns the SDK with the updated minimum version requirements of the underlying Firebase iOS library, ensuring continued compatibility and support. The updates are reflected across various project configuration files and the CMake build system.

Highlights

  • Minimum Deployment Target Update: The minimum iOS and tvOS deployment target for the Firebase C++ SDK and its integration tests has been updated from 13.0 to 15.0. This change is driven by the updated requirements of the underlying Firebase iOS library.
  • Configuration File Updates: Numerous Podfile and project.pbxproj files across various integration test directories have been modified to reflect the new 15.0 deployment target for both iOS and tvOS platforms.
  • Build System Adjustments: CMake toolchain files (apple.toolchain.cmake, ios.cmake, ios_simulator.cmake) have been updated to set the default and explicit deployment targets to 15.0, including specific handling for Mac Catalyst builds.
  • Release Notes Documentation: The release_build_files/readme.md has been updated to include a release note informing users about the new minimum iOS deployment target.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 16, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum iOS deployment target to 15.0 across the project, which is a necessary change to align with the underlying Firebase iOS SDK. The changes are comprehensive, touching Podfiles, Xcode project files, and CMake configurations.

I've identified a few minor areas for improvement in some of the Podfiles where platform declarations are redundant. Addressing these will help keep the configuration files clean and maintainable. Otherwise, the changes look correct and consistent with the goal of the PR.

@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Jul 16, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2025 •
edited
Loading

✅  Integration test succeeded!

Requested by @a-maurice on commit 814127d
Last updated: Thu Jul 17 12:46 PDT 2025
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 17, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 17, 2025
@a-maurice a-maurice merged commit 814127d into main Jul 17, 2025
50 of 51 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 17, 2025
@a-maurice a-maurice deleted the am-ios_minimum branch July 17, 2025 18:05
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 17, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a-maurice