-
Notifications
You must be signed in to change notification settings - Fork 266
fix: set go.mod version to actual min version #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Release 4.12.0
This reverts commit 32af2b8.
Merged
jonathanedey
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you @anuraaga for helping to resolve this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we see in #694, the actual minimum supported version is 1.23, but with
go 1.24
in the mod, dependent effectively require 1.24. The CI in this repo passes I think becausetoolchain
causes Go 1.23 to just automatically download 1.24 and run it, effectively making the 1.23 CI workflow the same as 1.24.The root cause of the go version is a transitive dependency on go-jose, go-jose/go-jose#184. I would encourage adding to that issue to explain how problematic that is. In the meantime, while keeping to 4.0.5 (the version after the CVE) can't completely protect downstream users from tools like dependabot, at least it can protect them from
go mod tidy
which is harder to have ignore rules for.Also, we use
1.23.0
instead of1.23
because it corresponds to the first released version of Go 1.23, while the latter includes prereleases.