Added additional proxy URL verification #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
joohoi
requested changes
Feb 2, 2023
Member
joohoi
left a comment
There was a problem hiding this comment.
LGTM with this proposed small nit
Co-authored-by: Joona Hoikkala <joohoi@users.noreply.github.com>
Contributor
Author
good catch! Committed. |
joohoi
added a commit
that referenced
this pull request
Feb 3, 2023
* Added additional proxy URL verification * Update pkg/ffuf/optionsparser.go Co-authored-by: Joona Hoikkala <joohoi@users.noreply.github.com> --------- Co-authored-by: Joona Hoikkala <joohoi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds additional checking for proxy and replay-proxy parameters, as well as adding some tests to make sure the parser is working how it's expected to. Go's
url.parsealone does not provide enough verification to determine whether a given URL matches the requirements for a proxy passed to a HTTP transport.Fixes: #573