Fix a recursion bug (#377) #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specified (#377) This fixes the situation where the URL port is specified from the command line and the "Location" redirection header contains an absolute URL path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursion does not work when the user provides port information in the URL and the site returns redirection status code (3xx) with a
Locationheader containing absolute URL path. Bug (#377).Line responsible:
ffuf/pkg/ffuf/response.go
Line 46 in 965f282
This line drops the port info when
redirectUrlis an absolute path and is the same asbaseUrl.This PR fixes the bug by making sure that the above situation is handled differently than when the
redirectUrlcontains a relative path.