-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update README.md #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #499
Conversation
Installing executables with "go get" in module mode is deprecated. "go install pkg@version" should be used instead. For more information, see https://golang.org/doc/go-get-install-deprecation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This is a good documentation change.
However, I think the required Go version mentioned here should be changed to 1.16 at the same time in order to not to cause confusion if go install
doesn't work as expected.
CONTRIBUTORS.md
Outdated
@@ -35,3 +35,4 @@ | |||
* [SolomonSklash](https://github.com/SolomonSklash) | |||
* [l4yton](https://github.com/l4yton) | |||
* [xfgusta](https://github.com/xfgusta) | |||
* [adilsoybali](https://github.com/adilsoybali) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list should be kept in alphabetically sorted order, can you make that change?
Hi @joohoi. I made the changes you requested. If there's anything else that needs to change, I can do that too. Thank you, have a nice day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response. It's all good now, merging!
* Update CONTRIBUTORS.md * Update README.md Installing executables with "go get" in module mode is deprecated. "go install pkg@version" should be used instead. For more information, see https://golang.org/doc/go-get-install-deprecation * Update CONTRIBUTORS.md * Update README.md Co-authored-by: Joona Hoikkala <joohoi@users.noreply.github.com>
Description
Installing executables with "go get" in module mode is deprecated.
"go install pkg@version" should be used instead.
For more information, see https://golang.org/doc/go-get-install-deprecation