这是indexloc提供的服务,不要输入任何密码
Skip to content

Update README.md #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2022
Merged

Update README.md #499

merged 5 commits into from
Jan 22, 2022

Conversation

adilsoybali
Copy link
Contributor

Description

Installing executables with "go get" in module mode is deprecated.
"go install pkg@version" should be used instead.
For more information, see https://golang.org/doc/go-get-install-deprecation

Installing executables with "go get" in module mode is deprecated.
"go install pkg@version" should be used instead.
For more information, see https://golang.org/doc/go-get-install-deprecation
Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is a good documentation change.

However, I think the required Go version mentioned here should be changed to 1.16 at the same time in order to not to cause confusion if go install doesn't work as expected.

CONTRIBUTORS.md Outdated
@@ -35,3 +35,4 @@
* [SolomonSklash](https://github.com/SolomonSklash)
* [l4yton](https://github.com/l4yton)
* [xfgusta](https://github.com/xfgusta)
* [adilsoybali](https://github.com/adilsoybali)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list should be kept in alphabetically sorted order, can you make that change?

@adilsoybali
Copy link
Contributor Author

Hi @joohoi. I made the changes you requested. If there's anything else that needs to change, I can do that too. Thank you, have a nice day.

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response. It's all good now, merging!

@joohoi joohoi merged commit 64860e4 into ffuf:master Jan 22, 2022
joohoi added a commit that referenced this pull request Feb 3, 2023
* Update CONTRIBUTORS.md

* Update README.md

Installing executables with "go get" in module mode is deprecated.
"go install pkg@version" should be used instead.
For more information, see https://golang.org/doc/go-get-install-deprecation

* Update CONTRIBUTORS.md

* Update README.md

Co-authored-by: Joona Hoikkala <joohoi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants