Include full line colors #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joohoi
requested changes
May 16, 2021
Member
joohoi
left a comment
There was a problem hiding this comment.
Thanks for the PR! This looks solid, unfortunately there was work done on the same parts of the codebase simultaneously, so I need to ask you to resolve the merge conflict.
Contributor
Author
|
I think it's ready to merge now. |
joohoi
approved these changes
May 16, 2021
Member
joohoi
left a comment
There was a problem hiding this comment.
LGTM, merging! Thanks again for the PR!
joohoi
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Include full line colors * Update CHANGELOG and CONTRIBUTORS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #349