Fix an issue where output file was created regardless of -or #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpy
reviewed
Jun 5, 2021
| // SaveFile saves the current results to a file of a given type | ||
| func (s *Stdoutput) SaveFile(filename, format string) error { | ||
| var err error | ||
| if s.config.OutputSkipEmptyFile && len(s.Results) == 0 { |
There was a problem hiding this comment.
The length of s.Results is not guaranteed to have the results stored in it at the time of this check. This is because they may still be sitting in s.CurrentResults having not been appended. This means when we use the -or argument it will always fail to create a file!
We need to check the length of the result from append(s.Results, s.CurrentResults...) as you were doing previously inside each writeJSON, writeEJSON...
nit: it would be simpler to have one line like:
res = append(s.Results, s.CurrentResults...)
and use the res as an arg to pass to all the output functions.
joohoi
added a commit
that referenced
this pull request
Feb 3, 2023
* Fix an issue where output file was created regardless of -or * Add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.